[Plugin] "Red-Eye" removal

AfterShot Pro Plugins
michaeld
Posts: 11
Joined: Sun Jan 29, 2012 5:44 am
operating_system: Linux
System_Drive: N/A
32bit or 64bit: 32 Bit

[Plugin] "Red-Eye" removal

Post by michaeld »

Hi!

At this URL http://www.deindl.name/ASP-plugins/ you can download a first version of a "Red-Eye" removal plugin.

Usage:
1. Select the red pupil with a circle-layer. For best result make that circle as small as possible and set the "Feather" to the minimal value.
red_eyes-before.jpg
2. Check the "Enable" checkbox of the plugin.
red_eyes-after.jpg
What the plugin does is to replace the red-channel of a pixel with the average value of the blue and green channels, IF the red-channel is bigger than 1.5 times this average.

This is the first version of my plugin so a few things are left to do:
* Add controls for sensitivity and darkness of the pupil
* Translate to other languages
* Deal with animal eyes

Bye,
Michael

Edit: changed URL
You do not have the required permissions to view the files attached to this post.
Last edited by michaeld on Fri Apr 06, 2012 1:23 pm, edited 1 time in total.
FotoLars
Posts: 35
Joined: Thu Jan 12, 2012 11:58 am
operating_system: Linux
System_Drive: X
32bit or 64bit: 64 Bit
motherboard: Intel D975XBX2
processor: Intel QuadCore Q6700
ram: 8 GB
Video Card: NVIDIA Quadro NVS 295
Hard_Drive_Capacity: 8 TB
Monitor/Display Make & Model: 2xDell 30", 5120x1600 (2x2560x1600)

Re: [Plugin] "Red-Eye" removal

Post by FotoLars »

Hi!

Here, tested on several linux computers with different OS and DE flavours, this plugin doesn't show up after the installation.
Anyone seeing the same?

When reinstalled, an error is given:
"
/home/lars/Downloads/Plugins/AfterShot/mdRedEyes.afzplug

Unable to uninstall existing plugin: mdRedEyes.afplugin
Unable to delete /home/olmur/C/Aftershot/mdRedEye/windows-mac-readme.txt

Please contact the plugin author.
"

A PM with the logfile is on its way to the developer.


Cheers,


Lars Nilsson
Lund, Sweden
Paul Wossidlo
Posts: 6
Joined: Sat Feb 04, 2012 6:04 pm
operating_system: Windows 7 Home Premium
System_Drive: C
32bit or 64bit: 64 Bit
processor: AMD
ram: 2GB
Hard_Drive_Capacity: 250GB
Monitor/Display Make & Model: 15.6 inch laptop

Re: [Plugin] "Red-Eye" removal

Post by Paul Wossidlo »

I tried loading it on my Win7 machine...

ASP indicates it is there, but I don't see it under either "Plugins1" or "Plugins2". I noticed I have 5 plugins each installed under those two tabs (10 plugins total). Is there a limit to how many plugins you can load in ASP, or how many in each tab?

Paul
kaymann
Posts: 238
Joined: Tue Dec 14, 2010 5:25 pm
operating_system: Windows 10
System_Drive: C
32bit or 64bit: 64 Bit
motherboard: ASUS P8P67 PRO REV 3.1
processor: Intel i-7 6800K
ram: 32 GB
Video Card: NVidia GeForce RTX 2060
sound_card: Onboard
Hard_Drive_Capacity: 3.5 T
Monitor/Display Make & Model: MSI MAG 341CQ & Dell 2470
Corel programs: PSP 2019 Ult, Painter 2020, CorelDraw X7

Re: [Plugin] "Red-Eye" removal

Post by kaymann »

Paul Wossidlo wrote:I tried loading it on my Win7 machine...

ASP indicates it is there, but I don't see it under either "Plugins1" or "Plugins2". I noticed I have 5 plugins each installed under those two tabs (10 plugins total). Is there a limit to how many plugins you can load in ASP, or how many in each tab?

Paul
I have 5 plugin tabs but this plugin is not showing up...
FotoLars
Posts: 35
Joined: Thu Jan 12, 2012 11:58 am
operating_system: Linux
System_Drive: X
32bit or 64bit: 64 Bit
motherboard: Intel D975XBX2
processor: Intel QuadCore Q6700
ram: 8 GB
Video Card: NVIDIA Quadro NVS 295
Hard_Drive_Capacity: 8 TB
Monitor/Display Make & Model: 2xDell 30", 5120x1600 (2x2560x1600)

Re: [Plugin] "Red-Eye" removal

Post by FotoLars »

Hi!

This first version of Michael's plugin only supports Linux.


Cheers,

Lars Nilsson
Lund, Sweden
kaymann
Posts: 238
Joined: Tue Dec 14, 2010 5:25 pm
operating_system: Windows 10
System_Drive: C
32bit or 64bit: 64 Bit
motherboard: ASUS P8P67 PRO REV 3.1
processor: Intel i-7 6800K
ram: 32 GB
Video Card: NVidia GeForce RTX 2060
sound_card: Onboard
Hard_Drive_Capacity: 3.5 T
Monitor/Display Make & Model: MSI MAG 341CQ & Dell 2470
Corel programs: PSP 2019 Ult, Painter 2020, CorelDraw X7

Re: [Plugin] "Red-Eye" removal

Post by kaymann »

FotoLars wrote:Hi!

This first version of Michael's plugin only supports Linux.


Cheers,

Lars Nilsson
Lund, Sweden
We will wait then. thanks for the clarification.
Dutchmm
Posts: 297
Joined: Sun Feb 05, 2012 8:55 am
operating_system: Linux
System_Drive: N/A
32bit or 64bit: 64 Bit
motherboard: Asus 97
processor: Intel i7 4785T
ram: 16GB
Video Card: Onboard Intel
sound_card: Intel AC97
Hard_Drive_Capacity: 2.5TB
Monitor/Display Make & Model: Philips 28"
Corel programs: ASP 3 Pro (and 2 and 1 before)

Re: [Plugin] "Red-Eye" removal

Post by Dutchmm »

@Lars

When I look at my log file, the plugin section starts as follows:

Code: Select all

64098.973: Globals: systemhome ../supportfiles
64098.973: Globals: userhome /home/mike/.AfterShotPro
64098.974: 
====================  Plugins  =====================
      Name: 
Identifier: 
   Version: 1.0.0
      Path: 


      Name: Bez
Identifier: com.ferdinand-paris.bez
   Version: 1.0.0
      Path: /home/mike/Dropbox/ASP/Plugins/Bez.afplugin


      Name: CAQuest
Identifier: CAQuest
   Version: 2.0.1
      Path: /home/mike/Dropbox/ASP/Plugins/CAQuest.afplugin


      Name: FatToni
Identifier: sph.FatToni
   Version: 0.32.0
      Path: /home/mike/Dropbox/ASP/Plugins/FatToni.afplugin

Note that there is one plugin that has no name ... I would bet money (if I had any :D ) that this is our red eye tool

Mike
FotoLars
Posts: 35
Joined: Thu Jan 12, 2012 11:58 am
operating_system: Linux
System_Drive: X
32bit or 64bit: 64 Bit
motherboard: Intel D975XBX2
processor: Intel QuadCore Q6700
ram: 8 GB
Video Card: NVIDIA Quadro NVS 295
Hard_Drive_Capacity: 8 TB
Monitor/Display Make & Model: 2xDell 30", 5120x1600 (2x2560x1600)

Re: [Plugin] "Red-Eye" removal

Post by FotoLars »

Hi!

There is some minor building error in the plugin. It has an internal plugin identifier, name.deindl.mdRedEyes, but this one apparently doesn't register when ASP starts.

If one in the Info.afpxml file changes the wrong path given for windowsLibFile="/home/olmur/C/Aftershot/mdRedEye/windows-mac-readme.txt" to windowsLibFile="" then it loads correctly and shows up in the plugin tabs, even though it still doesn't register itself in ASP.


Cheers,

Lars Nilsson
Lund, Sweden
michaeld
Posts: 11
Joined: Sun Jan 29, 2012 5:44 am
operating_system: Linux
System_Drive: N/A
32bit or 64bit: 32 Bit

Re: [Plugin] "Red-Eye" removal

Post by michaeld »

Hi!

Thanks for your feedback.

I should have mentioned that it currently only runs on Linux. Windows and Mac versions are planned, assuming I find somebody to compile it for me.

I uploaded a new version 1.0.1 of my plugin to home.bawue.de/~olmur/plugins/mdRedEyes.afzplug
It fixes the deinstall problem and the log shows it's registering:
Name: mdRedEyes
Identifier: name.deindl.mdRedEyes
   Version: 1.0.1
      Path: <User Home>/Plugins/mdRedEyes.afplugin

[....]

76893.424: Registering AfterShot plugin...  "Vigne" 
76893.424: Registering AfterShot plugin...  "mdRedEyes" 
76893.424: Registering AfterShot plugin...  "zText"
@FotoLars: thanks for your PM. Unfortunately I seem to be unable to reply.

Bye,
Michael
andreas
Posts: 154
Joined: Thu Jan 12, 2012 1:53 pm
operating_system: Linux
System_Drive: X
32bit or 64bit: 64 Bit
motherboard: Asus in Workstation and Dell XPS Notebook
processor: i7-980 and i7-2720QM
ram: 12GB - 8GB
Video Card: ATI FireGL
sound_card: on board
Hard_Drive_Capacity: 4.5TB Rd10
Monitor/Display Make & Model: Samsung Syncmaster 2343sw
Location: DE - Wermelskirchen

Re: [Plugin] "Red-Eye" removal

Post by andreas »

Hi,

cool, works here on my Linux box.

Andreas
Linux - not Windows
Dutchmm
Posts: 297
Joined: Sun Feb 05, 2012 8:55 am
operating_system: Linux
System_Drive: N/A
32bit or 64bit: 64 Bit
motherboard: Asus 97
processor: Intel i7 4785T
ram: 16GB
Video Card: Onboard Intel
sound_card: Intel AC97
Hard_Drive_Capacity: 2.5TB
Monitor/Display Make & Model: Philips 28"
Corel programs: ASP 3 Pro (and 2 and 1 before)

Re: [Plugin] "Red-Eye" removal

Post by Dutchmm »

Great!

But you will need to remove manually the earlier 1.0.0 directory from ~/.AfterShotPro/Plugins - is this hard coded into the manifest?

Mike
andreas
Posts: 154
Joined: Thu Jan 12, 2012 1:53 pm
operating_system: Linux
System_Drive: X
32bit or 64bit: 64 Bit
motherboard: Asus in Workstation and Dell XPS Notebook
processor: i7-980 and i7-2720QM
ram: 12GB - 8GB
Video Card: ATI FireGL
sound_card: on board
Hard_Drive_Capacity: 4.5TB Rd10
Monitor/Display Make & Model: Samsung Syncmaster 2343sw
Location: DE - Wermelskirchen

Re: [Plugin] "Red-Eye" removal

Post by andreas »

andreas wrote:works here on my Linux box.
Hm, there are images which get green eyes with the plugin. I think the resulting colour should be always gray:

Rnew = Gnew = Bnew = (R*sr+G*sg+B*sb)/3*sd

sr, sg, sb are sliders for the colors
sd slider for the darkness in the result

Initial values may be sr=0.2, sg=1, sb=1, sr=1 to nearly eliminate the red channel. For animals perhaps sr=1, sg=0.2, sr=0.8 which can be set up by presets.

Andreas
Linux - not Windows
andreas
Posts: 154
Joined: Thu Jan 12, 2012 1:53 pm
operating_system: Linux
System_Drive: X
32bit or 64bit: 64 Bit
motherboard: Asus in Workstation and Dell XPS Notebook
processor: i7-980 and i7-2720QM
ram: 12GB - 8GB
Video Card: ATI FireGL
sound_card: on board
Hard_Drive_Capacity: 4.5TB Rd10
Monitor/Display Make & Model: Samsung Syncmaster 2343sw
Location: DE - Wermelskirchen

Re: [Plugin] "Red-Eye" removal

Post by andreas »

Dutchmm wrote:But you will need to remove manually the earlier 1.0.0 directory from ~/.AfterShotPro/Plugins
This may arise when the plugin identifier changed or perhaps when ASP does not recognised the plugin in the former version. ASP should remove all what is included in the Info.afpxml file resp. the whole folder on an update.

Andreas
Linux - not Windows
michaeld
Posts: 11
Joined: Sun Jan 29, 2012 5:44 am
operating_system: Linux
System_Drive: N/A
32bit or 64bit: 32 Bit

Re: [Plugin] "Red-Eye" removal

Post by michaeld »

Hi!

I uploaded version 1.1.0 to http://home.bawue.de/~olmur/plugins/mdRedEyes.afzplug. Details below.
andreas wrote: Hm, there are images which get green eyes with the plugin. I think the resulting colour should be always gray:
You are right. I missread a paper about read-eye removal.

[quote="andreas]Initial values may be sr=0.2, sg=1, sb=1, sr=1 to nearly eliminate the red channel. For animals perhaps sr=1, sg=0.2, sr=0.8 which can be set up by presets.[/quote]
Good suggestion. Have to think a bit how to arrange the UI for that (without using too much space).

The new version has sliders "Sensitivity" and "Luminance". The algorithm to "remove" red eyes is:

Code: Select all

mean_green_blue = (green + blue) / 2
If (red >= ((sensitivity * mean_green_blue) / 100):   R = G = B = (mean_green_blue * Luminance) / 100
In other words: "Sensitivity" says how much the red-channel has to dominate a pixel to be seen as red eye and luminance is a percentage of how luminant the corrected pixel will be.

Bye,
Michael
ogrizzo
Posts: 60
Joined: Fri Jan 13, 2012 7:45 pm
operating_system: Mac
System_Drive: Q
32bit or 64bit: 64 Bit
processor: 2.8 Ghz Intel Core i7
ram: 8 GB
Hard_Drive_Capacity: 1TB
Monitor/Display Make & Model: Integrated Apple iMac 27"

Re: [Plugin] "Red-Eye" removal

Post by ogrizzo »

michaeld wrote:Hi!

I uploaded version 1.1.0 to http://home.bawue.de/~olmur/plugins/mdRedEyes.afzplug. Details below.
Still only Linux?